Closed
Conversation
zivkovicmilos
approved these changes
Apr 9, 2025
Contributor
zivkovicmilos
left a comment
zivkovicmilos
left a comment
There was a problem hiding this comment.
Left a comment, otherwise looks alright 🙏
| GasUsedAmount := t.Response.GasUsed | ||
|
|
||
| // Calculate the gas price (gasFee / gasUsed) | ||
| gasPrice := float64(gasFeeAmount) / float64(GasUsedAmount) |
Contributor
There was a problem hiding this comment.
The gas used has no influence on the gas price, actually. The chain takes everything the user specified in gasFee as part of the tx, even though the tx itself took less gas than what the user specified in GasUsedAmount
See:
gnolang/gno#3805
ajnavarro
approved these changes
Apr 14, 2025
Contributor
ajnavarro
left a comment
ajnavarro
left a comment
There was a problem hiding this comment.
LGTM after checking @zivkovicmilos comment.
|
The RPC method for fetching the current minimum gas price has changed. This PR needs a bit of updating before review and merge. Moving to draft in the meantime. |
zivkovicmilos
suggested changes
Jul 23, 2025
Contributor
zivkovicmilos
left a comment
zivkovicmilos
left a comment
There was a problem hiding this comment.
Blocking as it's outdated now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions
This PR modifies the implementation introduced in PR #120.
Current Behavior
When calling the
getGasPricemethod, it returns the High, Average, and Low values ofGasUsed.Modifications